SourceLink consolidation #384
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 89 89
Lines 2531 2531
Branches 427 427
=======================================
Hits 1944 1944
Misses 466 466
Partials 121 121 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Review please, this one is just here to make development easier, not much to do here. |
|
@abergs what's the holdup? Anything I can help with? Does it have to do with passwordless.dev being integrated into bitwarden? |
|
Hi @Regenhardt. I appreciate the PR -- I just haven't had the free time available to properly review. |
|
@abergs Yo it's been like a month are you ok? |
So I just spent hours figuring out why my build wanted to include some beta version of SourceLink and why all the references in the libraries are set to "Update".
Turns out there's another Directory.Build.props I didn't see because I didn't look in the actual file system.
This change makes it more obvious what's going on and also updates the SourceLink reference in the Directory.Build.props so the projects don't have to do it themselves.
Edit: The GUID change is just VS migrating from the old project system to the new one (see dotnet/project-system#3079)